Skip to content

Conversation

@CJ-Johnson
Copy link
Contributor

@CJ-Johnson CJ-Johnson commented Nov 26, 2024

I noticed that these two utilities were not being used in the code examples of TotW #120. Hopefully this all checks out!

Also, while I'm here, I fixed the incorrect mailto address from @gmail.com to @google.com

@CJ-Johnson
Copy link
Contributor Author

Friendly ping @derekmauro :)

@derekmauro
Copy link
Member

Thanks for the reminder @CJ-Johnson. I'm actually in the process of getting a new technical writing team up to speed to manage this repo. Please be patient.

@CJ-Johnson
Copy link
Contributor Author

Fantastic! Thank you so much :) @derekmauro

@CJ-Johnson
Copy link
Contributor Author

Hey @derekmauro ! Just checking in. Were you able to form a team to handle reviews? Thanks!

@derekmauro
Copy link
Member

@axgillies - Can you look into importing this change? Or maybe the internal version is now releasable? I think the context here is that we published the tip before absl::Cleanup and absl::Status were part of the Abseil release.

@CJ-Johnson
Copy link
Contributor Author

Thanks for handing it off @derekmauro !

@axgillies Feel free to let me know if you'd like any updates before landing.

@CJ-Johnson
Copy link
Contributor Author

Hey @derekmauro It seems this hasn't been picked up yet. Are you able to ping the new reviewer? Thanks!

@axgillies
Copy link
Contributor

Thanks for bumping this up, CJ -- I've put this in my queue for this week.

@axgillies
Copy link
Contributor

It looks like we have two versions of this Tip that have gone out of sync, one internal and one externally proposed here. The internal version has been updated to add several of the changes in this PR. I'm going to create a new pull request from the internal version. CJ, can you sync to that version and then take another look at your change?

@axgillies
Copy link
Contributor

I synced the version of the tip in the repo with the internal version here:

#515

CJ, can you review and then update this change?

@CJ-Johnson
Copy link
Contributor Author

I synced the version of the tip in the repo with the internal version here:

#515

CJ, can you review and then update this change?

Thanks for the reply! I'm not the best with git and github but I managed to create the new, minimized change in a separate PR: #517

@CJ-Johnson CJ-Johnson closed this Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants